[PATCH 6/8] qemu_domain: Move TPM post parse code into qemuDomainTPMDefPostParse()

Peter Krempa pkrempa at redhat.com
Mon Aug 1 11:27:04 UTC 2022


On Mon, Jul 18, 2022 at 11:30:48 +0200, Michal Privoznik wrote:
> In the qemuDomainDefPostParse() we aim to fill in top level
> values, which require overall view of domain, or those parts of
> configuration that are not a device in domain XML (e.g. vCPUs).
> However, inside of qemuDomainDefTPMsPostParse(), which is called
> from aforementioned function, we do two tings:
> 
>   1) fill in missing info (TPM version), and
>   2) validate TPM definition.
> 
> Now, if 1) is moved into qemuDomainTPMDefPostParse() (the device
> post parse callback), then 2) can be moved into validation step.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_domain.c | 28 ++++++++++++++--------------

Reviewed-by: Peter Krempa <pkrempa at redhat.com>


More information about the libvir-list mailing list