[PATCH 4/6] qemuProcessQMPConnectMonitor: Connect to probing monitor with 'retry' set to false

Peter Krempa pkrempa at redhat.com
Tue Aug 2 12:51:46 UTC 2022


In 'qemuProcessQMPLaunch' qemu is very specifically launched using it's
internal '-daemonize' flag (see comment in the function) to ensure that
the monitor socket is ready and opened prior to attempting the monitor
connection.

This means we don't have to retry the connection to the monitor in
qemuMonitorOpen as the socket will be already there.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/qemu/qemu_process.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index 1cd55fe989..c51d704af8 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -9493,7 +9493,7 @@ qemuProcessQMPConnectMonitor(qemuProcessQMP *proc)

     proc->vm->pid = proc->pid;

-    if (!(proc->mon = qemuMonitorOpen(proc->vm, &monConfig, true,
+    if (!(proc->mon = qemuMonitorOpen(proc->vm, &monConfig, false,
                                       virEventThreadGetContext(proc->eventThread),
                                       &callbacks)))
         return -1;
-- 
2.36.1



More information about the libvir-list mailing list