[PATCH 0/6] qemu: Remove monitor socket waiting code
Jonathon Jongsma
jjongsma at redhat.com
Tue Aug 2 20:32:56 UTC 2022
On 8/2/22 7:51 AM, Peter Krempa wrote:
> We either pre-open a socket and pass the file descriptor to qemu or are
> guaranteed that the socket is open by other means.
>
> The qemu monitor code can be simplified a lot.
>
> Peter Krempa (6):
> qemu: process: Remove 'retry' argument from qemuConnectMonitor
> qemu: monitor: Remove 'timeout' argument from qemuMonitorOpen
> qemuMonitorTestNew: Call qemuMonitorOpen with 'retry' false
> qemuProcessQMPConnectMonitor: Connect to probing monitor with 'retry'
> set to false
> qemuMonitorOpenUnix: Remove 'retry' argument
> qemuMonitorOpenUnix: Don't overwrite 'ret' needlessly
>
> src/qemu/qemu_monitor.c | 59 +++++-------------------------------
> src/qemu/qemu_monitor.h | 4 +--
> src/qemu/qemu_process.c | 24 +++------------
> tests/qemumonitortestutils.c | 2 --
> 4 files changed, 13 insertions(+), 76 deletions(-)
>
Series looks good to me.
Reviewed-by: Jonathon Jongsma <jjongsma at redhat.com>
More information about the libvir-list
mailing list