[PATCH] qemu: Move CPU validation out of PostParse

Erik Skultety eskultet at redhat.com
Wed Aug 3 13:14:42 UTC 2022


On Wed, Aug 03, 2022 at 02:24:08PM +0200, Michal Privoznik wrote:
> The qemuDomainDefCPUPostParse() does a bit more than filling in
> missing info. It also validates CPU cache configuration. Move
> that code into qemuValidateDomainDefCpu() where the code fits
> better.
> 
> And since I need to fix indentation of existing code in
> qemuValidateDomainDefCpu(), I'm taking this opportunity and move
> error messages onto single line. Interestingly, this uncovers a
> bug we have in sc_prohibit_diagnostic_without_format syntax-check
> rule, because previously a virReportError() with a message
> spawned over three lines was not caught but not it is. But
> trying to understand that regex is a job for another time.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
Reviewed-by: Erik Skultety <eskultet at redhat.com>



More information about the libvir-list mailing list