[PATCH] qemu_process: Destroy domain's namespace after killing QEMU

[Martin Kletzander]

On Thu, Aug 04, 2022 at 12:52:43PM +0200, Michal Privoznik wrote:
>After QEMU is killed in qemuProcessStop() its mount namespace
>doesn't exist anymore, because it was the only process running
>there. Thus we should clear our internal flag that the domain has
>namespace enabled so that seclabel restore code does not try to
>enter it. We do the same in qemuProcessHandleMonitorEOF() but
>when it is us, who decides to kill QEMU rather than QEMU quitting
>we haven't seen EOF by the time qemuProcessStop() is called.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>---
> src/qemu/qemu_process.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
>index d29da63242..fbf460595b 100644
>--- a/src/qemu/qemu_process.c
>+++ b/src/qemu/qemu_process.c
>@@ -8265,6 +8265,9 @@ void qemuProcessStop(virQEMUDriver *driver,
>                                  VIR_QEMU_PROCESS_KILL_FORCE|
>                                  VIR_QEMU_PROCESS_KILL_NOCHECK));
>
>+    /* Its namespace is also gone then. */
>+    qemuDomainDestroyNamespace(driver, vm);
>+
>     qemuDomainCleanupRun(driver, vm);
>
>     qemuExtDevicesStop(driver, vm);
>-- 
>2.35.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220804/d9723029/attachment.sig>