[PATCH 7/7] qemu: deprecate query-cpus-fast capability

Peter Krempa pkrempa at redhat.com
Mon Aug 8 14:51:52 UTC 2022


On Mon, Aug 08, 2022 at 15:06:08 +0200, Paolo Bonzini wrote:
> All supported versions of QEMU have the command.
> 
> Signed-off-by: Paolo Bonzini <pbonzini at redhat.com>
> ---
>  src/qemu/qemu_capabilities.c | 4 ++--
>  src/qemu/qemu_capabilities.h | 2 +-
>  tests/qemuhotplugtest.c      | 2 --
>  3 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index c2c55f4800..1eb006e3ef 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -468,7 +468,7 @@ VIR_ENUM_IMPL(virQEMUCaps,
>                "qcow2-luks", /* QEMU_CAPS_QCOW2_LUKS */
>                "pcie-pci-bridge", /* QEMU_CAPS_DEVICE_PCIE_PCI_BRIDGE */
>                "seccomp-blacklist", /* X_QEMU_CAPS_SECCOMP_BLACKLIST */
> -              "query-cpus-fast", /* QEMU_CAPS_QUERY_CPUS_FAST */
> +              "query-cpus-fast", /* X_QEMU_CAPS_QUERY_CPUS_FAST */
>                "disk-write-cache", /* QEMU_CAPS_DISK_WRITE_CACHE */
>  
>                /* 290 */
> @@ -1212,7 +1212,7 @@ struct virQEMUCapsStringFlags virQEMUCapsCommands[] = {
>      { "query-cpu-model-expansion", QEMU_CAPS_QUERY_CPU_MODEL_EXPANSION },
>      { "query-cpu-definitions", QEMU_CAPS_QUERY_CPU_DEFINITIONS },
>      { "query-named-block-nodes", QEMU_CAPS_QUERY_NAMED_BLOCK_NODES },
> -    { "query-cpus-fast", QEMU_CAPS_QUERY_CPUS_FAST },
> +    { "query-cpus-fast", X_QEMU_CAPS_QUERY_CPUS_FAST },

We no longer need to actually probe this capability, so this line should
be dropped.

This will require that the output files are re-generated, but we can do
that before pushing.


More information about the libvir-list mailing list