[libvirt PATCH 13/16] util: replace g_snprintf with g_autofreed g_strdup_printf in viriptables.c

Laine Stump laine at redhat.com
Mon Aug 22 13:31:47 UTC 2022


Signed-off-by: Laine Stump <laine at redhat.com>
---
 src/util/viriptables.c | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/src/util/viriptables.c b/src/util/viriptables.c
index e9886a200e..6275760de4 100644
--- a/src/util/viriptables.c
+++ b/src/util/viriptables.c
@@ -163,10 +163,7 @@ iptablesInput(virFirewall *fw,
               int action,
               int tcp)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, layer,
                        "--table", "filter",
@@ -187,10 +184,7 @@ iptablesOutput(virFirewall *fw,
                int action,
                int tcp)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, layer,
                        "--table", "filter",
@@ -1028,10 +1022,7 @@ iptablesOutputFixUdpChecksum(virFirewall *fw,
                              int port,
                              int action)
 {
-    char portstr[32];
-
-    g_snprintf(portstr, sizeof(portstr), "%d", port);
-    portstr[sizeof(portstr) - 1] = '\0';
+    g_autofree char *portstr = g_strdup_printf("%d", port);
 
     virFirewallAddRule(fw, VIR_FIREWALL_LAYER_IPV4,
                        "--table", "mangle",
-- 
2.37.1



More information about the libvir-list mailing list