[PATCH RFC 0/5] storage: Drop the sheepdog storage driver backend

Ján Tomko jtomko at redhat.com
Thu Aug 25 13:53:07 UTC 2022


On a Monday in 2022, Peter Krempa wrote:
>The sheepdog project is abandoned, with last commit in 2018. QEMU
>already removed the storage backend in qemu-6.1
>
>This series removes the libvirt storage driver backend.
>
>This series is RFC as of:
>1/5: I'm not 100% sure whether 'Obsoletes:' is the correct way to
>     deprecate a subpackage in Fedora, but it certainly does the correct
>     thing.
>
>4/5: I personally don't mind that the build option will be kept to
>     prevent breakage of builds, but I can see the value in dropping it
>     and anyone building libvirt having to knowingly acknowledge that
>     they don't need sheepdog any more.
>     (This patch intentionally omits the S-o-b line as the commit
>      message will need to be rewritten if it's going to be pushed)
>
>This series does _not_ remove the ability to use qemu-6.0 and older with
>sheepdog as the qemu driver bits are left untouched.
>
>Peter Krempa (5):
>  spec: Drop libvirt-daemon-driver-storage-sheepdog package
>  tests: Remove storage pool/vol tests for sheepdog
>  Remove support for building the sheepdog storage driver backend
>  build: Drop the 'storage_sheepdog' build option completely
>  storage: Remove the sheepdog storage driver backend source code
>
> docs/formatstorage.rst                        |   6 +-
> docs/kbase/rpm-deployment.rst                 |   6 +-
> docs/storage.rst                              |   3 +-
> libvirt.spec.in                               |  38 +-
> meson.build                                   |  11 -
> meson_options.txt                             |   1 -
> po/POTFILES                                   |   1 -
> src/storage/meson.build                       |  25 --
> src/storage/storage_backend.c                 |   6 -
> src/storage/storage_backend_sheepdog.c        | 376 ------------------
> src/storage/storage_backend_sheepdog.h        |  25 --
> src/storage/storage_backend_sheepdog_priv.h   |  30 --
> tests/meson.build                             |   6 -
> tests/storagebackendsheepdogtest.c            | 205 ----------
> tests/storagepoolxml2argvtest.c               |   1 -
> tests/storagepoolxml2xmlin/pool-sheepdog.xml  |   8 -
> tests/storagepoolxml2xmlout/pool-sheepdog.xml |  11 -
> tests/storagepoolxml2xmltest.c                |   1 -
> tests/storagevolxml2xmlin/vol-sheepdog.xml    |  10 -
> tests/storagevolxml2xmlout/vol-sheepdog.xml   |   8 -
> tests/storagevolxml2xmltest.c                 |   1 -
> tools/virsh.c                                 |   3 -
> 22 files changed, 12 insertions(+), 770 deletions(-)
> delete mode 100644 src/storage/storage_backend_sheepdog.c
> delete mode 100644 src/storage/storage_backend_sheepdog.h
> delete mode 100644 src/storage/storage_backend_sheepdog_priv.h
> delete mode 100644 tests/storagebackendsheepdogtest.c
> delete mode 100644 tests/storagepoolxml2xmlin/pool-sheepdog.xml
> delete mode 100644 tests/storagepoolxml2xmlout/pool-sheepdog.xml
> delete mode 100644 tests/storagevolxml2xmlin/vol-sheepdog.xml
> delete mode 100644 tests/storagevolxml2xmlout/vol-sheepdog.xml
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220825/0d216c22/attachment.sig>


More information about the libvir-list mailing list