[PATCH 00/10] virDomainControllerDef(Validate|Parse|Format): Refactor and fix several problems

[Ján Tomko]

On a Friday in 2022, Peter Krempa wrote:
>A relatively simple-looking bug report (see 10/10) lead me looking and
>finding few more problems.
>
>Peter Krempa (10):
>  virDomainControllerDefValidate: Un-break lines in error messages
>  virDomainControllerDefFormat: Use proper type for enum
>  virDomainControllerDefFormat: Split out formatting of PCI controller
>  virDomainControllerDefFormatPCI: Refactor formatting of '<target>'
>    subelement
>  virDomainControllerDefParseXML: Fix broken code indentation when
>    parsing PCI contoller target
>  virDomainControllerDefParseXML: Fix broken error reporting when
>    parsing 'index'
>  virDomainControllerDefParseXML: Remove explicit checks for negative
>    value
>  virDomainControllerDefParseXML: Parse 'index' by virXMLPropInt
>  virDomainControllerDefParseXML: Return early if there's unexpectedly
>    many elements
>  virDomainControllerDefParseXML: Reject '-1' for PCI controller target
>    properties
>
> src/conf/domain_conf.c                        | 286 ++++++++----------
> src/conf/domain_validate.c                    |  24 +-
> .../pci-bridge-negative-index-invalid.err     |   2 +-
> 3 files changed, 132 insertions(+), 180 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220826/2768e1dc/attachment.sig>