[PATCH 00/13] virsh: Don't reimplement virXPathNodeSet

[Ján Tomko]

On a Friday in 2022, Peter Krempa wrote:
>This series converts open-coded virXPathNodeSet to the proper helper use
>and also adds --print-xml option to commands using xmlXpathEval which
>didn't have it.
>
>Peter Krempa (13):
>  virsh: Add --print-xml option for 'detach-interface'
>  virshDomainDetachInterface: Use virXPathNodeSet instead of
>    xmlXpathEval
>  virsh: Add --print-xml option for 'domif-setlink'
>  virsh: cmdDomIfSetLink: Use virXPathNodeSet instead of xmlXpathEval
>  virsh: Refactor cleanup in 'cmdVolClone'
>  virsh: Add --print-xml flag for 'vol-clone' command
>  virsh: virshMakeCloneXML: Use virXPathNode instead of xmlXPathEval
>  virsh: cmdDetachDisk: Refactor cleanup
>  virsh: cmdChangeMedia: Refactor cleanup
>  virshFindDisk: Use virXPathNodeSet instead of xmlXPathEval
>  virshFindDisk: Sanitize removable media check
>  util: xml: Introduce virXMLNodeGetSubelement
>  virshFindDisk: Sanitize use of 'tmp' variable
>
> docs/manpages/virsh.rst  |  15 +-
> src/libvirt_private.syms |   1 +
> src/util/virxml.c        |  23 +++
> src/util/virxml.h        |   5 +
> tools/virsh-domain.c     | 298 ++++++++++++++++++---------------------
> tools/virsh-volume.c     |  61 ++++----
> 6 files changed, 207 insertions(+), 196 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20221202/9312de70/attachment.sig>