[PATCH 2/4] qemu_extdevice: Init paths in qemuExtDevicesPrepareDomain()

Michal Privoznik mprivozn at redhat.com
Mon Dec 5 12:17:29 UTC 2022


The path generation phase belongs conceptually into domain
preparation phase and not host preparation. Move
qemuExtDevicesInitPaths() call from qemuExtDevicesPrepareHost()
into qemuExtDevicesPrepareDomain().

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 src/qemu/qemu_extdevice.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_extdevice.c b/src/qemu/qemu_extdevice.c
index 3eaf6571a2..34454891f6 100644
--- a/src/qemu/qemu_extdevice.c
+++ b/src/qemu/qemu_extdevice.c
@@ -97,6 +97,9 @@ qemuExtDevicesPrepareDomain(virQEMUDriver *driver,
     int ret = 0;
     size_t i;
 
+    if (qemuExtDevicesInitPaths(driver, vm->def) < 0)
+        return -1;
+
     for (i = 0; i < vm->def->nvideos; i++) {
         virDomainVideoDef *video = vm->def->videos[i];
 
@@ -134,9 +137,6 @@ qemuExtDevicesPrepareHost(virQEMUDriver *driver,
     virDomainDef *def = vm->def;
     size_t i;
 
-    if (qemuExtDevicesInitPaths(driver, def) < 0)
-        return -1;
-
     for (i = 0; i < def->ntpms; i++) {
         virDomainTPMDef *tpm = def->tpms[i];
 
-- 
2.37.4



More information about the libvir-list mailing list