[PATCH 0/5] qemu: Prefer PNG for domain screenshots

Martin Kletzander mkletzan at redhat.com
Wed Dec 7 11:48:59 UTC 2022


On Wed, Dec 07, 2022 at 12:20:48PM +0100, Michal Privoznik wrote:
>Whilst preparing for libvirt-php release, I want to ditch its imagick
>dependency which is needed to convert PPM to PNG. But I've learned that
>QEMU is able to return PNG already which looks more versatile than PPM
>anyways.
>
>Michal Prívozník (5):
>  qemu_caps: Introduce QEMU_CAPS_SCREENSHOT_FORMAT_PNG
>  qemu_monitor: Debug print all arguments in qemuMonitorScreendump()
>  qemu_monitor: Extend qemuMonitorScreendump() for @format
>  qemu: Prefer PNG for domain screenshots
>  NEWS: Document change of screenshot format for QEMU

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>
> NEWS.rst                                         |  4 ++++
> src/qemu/qemu_capabilities.c                     |  2 ++
> src/qemu/qemu_capabilities.h                     |  1 +
> src/qemu/qemu_driver.c                           | 13 +++++++++++--
> src/qemu/qemu_monitor.c                          |  6 ++++--
> src/qemu/qemu_monitor.h                          |  1 +
> src/qemu/qemu_monitor_json.c                     |  2 ++
> src/qemu/qemu_monitor_json.h                     |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.ppc64.xml  |  1 +
> tests/qemucapabilitiesdata/caps_7.1.0.x86_64.xml |  1 +
> tests/qemucapabilitiesdata/caps_7.2.0.x86_64.xml |  1 +
> tests/qemumonitorjsontest.c                      |  2 +-
> 12 files changed, 30 insertions(+), 5 deletions(-)
>
>-- 
>2.37.4
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20221207/ee045867/attachment.sig>


More information about the libvir-list mailing list