[libvirt PATCH 02/21] meson: remove obsolete check for EPOLL_CLOEXEC

Daniel P. Berrangé berrange at redhat.com
Thu Dec 8 14:35:06 UTC 2022


The EPOLL_CLOEXEC constant was introduced to Linux in

  commit a0998b50c3f0b8fdd265c63e0032f86ebe377dbf
  Author: Ulrich Drepper <drepper at redhat.com>
  Date:   Wed Jul 23 21:29:27 2008 -0700

    flag parameters: epoll_create

This is old enough that all our supported platforms can be assumed
to have this feature. For added fun this whole meson check was
semantically insane because EPOLL_CLOEXEC is not a valid arg
to unshare().

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 meson.build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index 22679db85d..f313767cfe 100644
--- a/meson.build
+++ b/meson.build
@@ -1532,7 +1532,7 @@ if not get_option('driver_lxc').disabled() and host_machine.system() == 'linux'
 #include <sys/epoll.h>
 
 void main(void) {
-    unshare(!(LO_FLAGS_AUTOCLEAR + EPOLL_CLOEXEC));
+    unshare(!(LO_FLAGS_AUTOCLEAR));
 }
   '''
   if cc.compiles(lxc_support_code, name: 'lxc support', args: '-D_GNU_SOURCE')
-- 
2.38.1



More information about the libvir-list mailing list