[libvirt PATCH 06/21] meson: remove obsolete check for ETHTOOL_GGSO

Daniel P. Berrangé berrange at redhat.com
Thu Dec 8 14:35:10 UTC 2022


The ETHTOOL_GGSO constant was introduced to Linux in

  commit 37c3185a02d4b85fbe134bf5204535405dd2c957
  Author: Herbert Xu <herbert at gondor.apana.org.au>
  Date:   Thu Jun 22 03:07:29 2006 -0700

    [NET]: Added GSO toggle

This is old enough that all our supported platforms can be assumed
to have this feature.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 meson.build          | 1 -
 src/util/virnetdev.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/meson.build b/meson.build
index 0a09e510c7..69d79963f7 100644
--- a/meson.build
+++ b/meson.build
@@ -654,7 +654,6 @@ symbols = [
   [ 'linux/ethtool.h', 'ETH_FLAG_NTUPLE' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_RXHASH' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_LRO' ],
-  [ 'linux/ethtool.h', 'ETHTOOL_GGSO' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GGRO' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFLAGS' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFEATURES' ],
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index c21cf69be1..3fdf71e41e 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -3083,9 +3083,7 @@ virNetDevGetEthtoolFeatures(const char *ifname,
         {ETHTOOL_GTXCSUM, VIR_NET_DEV_FEAT_GTXCSUM},
         {ETHTOOL_GSG, VIR_NET_DEV_FEAT_GSG},
         {ETHTOOL_GTSO, VIR_NET_DEV_FEAT_GTSO},
-# if WITH_DECL_ETHTOOL_GGSO
         {ETHTOOL_GGSO, VIR_NET_DEV_FEAT_GGSO},
-# endif
 # if WITH_DECL_ETHTOOL_GGRO
         {ETHTOOL_GGRO, VIR_NET_DEV_FEAT_GGRO},
 # endif
-- 
2.38.1



More information about the libvir-list mailing list