[libvirt PATCH 12/21] meson: remove obsolete check for ETH_FLAG_RXHASH

Daniel P. Berrangé berrange at redhat.com
Thu Dec 8 14:35:16 UTC 2022


The ETH_FLAG_RXHASH constant was introduced to Linux in

  commit b00fabb4020d17bda4bea59507e09fadf573088d
  Author: stephen hemminger <shemminger at vyatta.com>
  Date:   Mon Mar 29 14:47:27 2010 +0000

    netdev: ethtool RXHASH flag

This is old enough that all our supported platforms can be assumed
to have this feature.

Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
---
 meson.build          | 1 -
 src/util/virnetdev.c | 2 --
 2 files changed, 3 deletions(-)

diff --git a/meson.build b/meson.build
index d9af1ac36a..ff6908d3c4 100644
--- a/meson.build
+++ b/meson.build
@@ -650,7 +650,6 @@ symbols = [
   # Check whether endian provides handy macros.
   [ 'endian.h', 'htole64' ],
 
-  [ 'linux/ethtool.h', 'ETH_FLAG_RXHASH' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFEATURES' ],
   [ 'linux/ethtool.h', 'ETHTOOL_SCOALESCE' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GCOALESCE' ],
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index 5ef4687191..52b8d53ed8 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -3093,9 +3093,7 @@ virNetDevGetEthtoolFeatures(const char *ifname,
         {ETH_FLAG_RXVLAN, VIR_NET_DEV_FEAT_RXVLAN},
         {ETH_FLAG_TXVLAN, VIR_NET_DEV_FEAT_TXVLAN},
         {ETH_FLAG_NTUPLE, VIR_NET_DEV_FEAT_NTUPLE},
-# if WITH_DECL_ETH_FLAG_RXHASH
         {ETH_FLAG_RXHASH, VIR_NET_DEV_FEAT_RXHASH},
-# endif
     };
 
     for (i = 0; i < G_N_ELEMENTS(ethtool_cmds); i++) {
-- 
2.38.1



More information about the libvir-list mailing list