[PATCH 09/11] virStorageBackendRBDOpenRADOSConn: Don't log the RBD key
Ján Tomko
jtomko at redhat.com
Mon Dec 12 12:10:04 UTC 2022
On a Friday in 2022, Peter Krempa wrote:
>'virStorageBackendRBDRADOSConfSet' logs it's arguments but it's also
*its
>used to set the RBD secret/key.
>
>All the security theatre with securely erasing the string we do to fetch
>the secret would be quite pointless if we log it thus introduce
>virStorageBackendRBDRADOSConfSetQuiet and use it to avoid logging the
>password.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/storage/storage_backend_rbd.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20221212/0e1efeea/attachment.sig>
More information about the libvir-list
mailing list