[PATCH 4/7] spec: Move lockd plugin to a new subpackage libvirt-daemon-plugin-lockd

[Daniel P. Berrangé]

On Mon, Dec 12, 2022 at 03:39:44PM -0700, Jim Fehlig wrote:
> On 12/11/22 11:22, Andrea Bolognani wrote:
> > On Fri, Dec 02, 2022 at 05:17:35PM -0700, Jim Fehlig wrote:
> > > +%package daemon-plugin-lockd
> > > +Plugin for virtlockd
> > > +Requires: libvirt-libs = %{version}-%{release}
> > 
> > Maybe libvirt-daemon-lock-plugin-lockd? A bit verbose, but would help
> > better differenciate it from other loadable drivers.
> > 
> > Alternatively we could follow the example set by the storage drivers
> > and go with libvirt-daemon-driver-lock-lockd. Pretty ugly, and also
> > kind of inaccurate because, unlike the storage driver, the lock
> > functionality can't be loaded into the monolithic daemon and always
> > lives, by design, in a separate daemon.
> 
> I slightly prefer libvirt-daemon-lock-plugin-lockd. Yes it's verbose, but it
> does a better job of describing the thing.
> 
> > Either way, we should take the existing libvirt-lock-sanlock package
> > and convert it to the new naming convention for consistency.
> > 
> > Both packages should depend on libvirt-daemon-lock too, instead of
> > just the libraries.
> > 
> > > +%files daemon-plugin-lockd
> > > +%dir %attr(0755, root, root) %{_libdir}/libvirt/lock-driver
> > 
> > I believe this directory belongs to either the libvirt-daemon-lock
> > package (more likely) or possibly the libvirt-daemon-common package.
> 
> Yep, I think libvirt-daemon-lock is correct. Thanks a lot for the review and
> comments!

libvirt-daemon-lock isn't the right place, as that's the home
for virtlockd.

This directory is what contains either lockd.so or sanlock.so,
which are both client side plugins for other daemons.

It could go in libvirt-daemon-common, or it can just be
duplicated in both the daemon-plugin-lockd and daemon-lock-sanlock
packages - its fine to have multiple RPMs own the same dir, as long
as permissions/user/group match


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|