[libvirt PATCH] qemu: Don't warn when releasing a released job

Jiri Denemark jdenemar at redhat.com
Tue Dec 13 13:47:41 UTC 2022


When qemuDomainObjReleaseAsyncJob is called when the current async job
is already released we emit quite useless warning which was implemented
to warn about releasing a job owned by another thread.

Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
---
 src/qemu/qemu_domainjob.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/qemu/qemu_domainjob.c b/src/qemu/qemu_domainjob.c
index 4d320f075e..8d958b9d21 100644
--- a/src/qemu/qemu_domainjob.c
+++ b/src/qemu/qemu_domainjob.c
@@ -647,7 +647,8 @@ qemuDomainObjReleaseAsyncJob(virDomainObj *obj)
     VIR_DEBUG("Releasing ownership of '%s' async job",
               virDomainAsyncJobTypeToString(obj->job->asyncJob));
 
-    if (obj->job->asyncOwner != virThreadSelfID()) {
+    if (obj->job->asyncOwner != 0 &&
+        obj->job->asyncOwner != virThreadSelfID()) {
         VIR_WARN("'%s' async job is owned by thread %llu",
                  virDomainAsyncJobTypeToString(obj->job->asyncJob),
                  obj->job->asyncOwner);
-- 
2.39.0



More information about the libvir-list mailing list