[libvirt PATCH 29/30] api: document support for external snapshot deletion
Peter Krempa
pkrempa at redhat.com
Tue Dec 13 16:30:01 UTC 2022
On Thu, Dec 08, 2022 at 14:31:05 +0100, Pavel Hrdina wrote:
> Now that deletion of external snapshot is implemented document the
> current virDomainSnapshotDelete supported state.
>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
> src/libvirt-domain-snapshot.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/src/libvirt-domain-snapshot.c b/src/libvirt-domain-snapshot.c
> index 2917b8bd90..ab6a029915 100644
> --- a/src/libvirt-domain-snapshot.c
> +++ b/src/libvirt-domain-snapshot.c
> @@ -1075,6 +1075,13 @@ virDomainRevertToSnapshot(virDomainSnapshotPtr snapshot,
> * libvirt metadata to track snapshots, then this flag is silently
> * ignored.
> *
> + * Since libvirt 9.0.0 deletion of external snapshots is supported
> + * for QEMU driver. Using @flags VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN
> + * and VIR_DOMAIN_SNAPSHOT_DELETE_CHILDREN_ONLY is not supported with
> + * external snapshots. In case that daemon process is terminated
> + * while the snapshot delete is in process the operation will be
> + * aborted when the daemon starts again.
> + *
This doesn't look like the best place for this kind of documentation but
I don't have a better suggestion.
Reviewed-by: Peter Krempa <pkrempa at redhat.com>
More information about the libvir-list
mailing list