[PATCH V2 6/9] spec: Move common files to a new subpackage libvirt-daemon-common

Andrea Bolognani abologna at redhat.com
Wed Dec 14 18:22:44 UTC 2022


On Wed, Dec 14, 2022 at 09:56:28AM -0800, Andrea Bolognani wrote:
> On Tue, Dec 13, 2022 at 05:30:59PM -0700, Jim Fehlig wrote:
> > @@ -450,7 +446,6 @@ Requires: module-init-tools
> >  Requires: iproute
> >  # for /sbin/tc
> >  Requires: iproute-tc
> > -Requires: polkit >= 0.112
> >  %if %{with_dmidecode}
> >  # For virConnectGetSysinfo
> >  Requires: dmidecode
> > @@ -464,6 +459,21 @@ Requires: numad
> >  Requires: dbus
> >  # For uid creation during pre
> >  Requires(pre): shadow-utils
>
> Have you verified that all of these runtime dependencies are really
> only needed when running the monolithic daemon?
>
> I would expect that, for example, the iproute dependency would have
> to be moved to the libvirt-daemon-driver-network package and so on.
>
> Some of them might even need to be duplicated to ensure that a pure
> split daemon scenario works correctly.

And I think the %pre snippet that handles creation of the libvirt
group needs to be moved to the common package as well, to allow
members of the group to perform privileged operations in a pure split
daemon deployment.

-- 
Andrea Bolognani / Red Hat / Virtualization



More information about the libvir-list mailing list