[PATCH V2 4/9] spec: Move lockd plugin to a new subpackage

Jim Fehlig jfehlig at suse.com
Wed Dec 14 22:45:21 UTC 2022


On 12/14/22 10:47, Andrea Bolognani wrote:
> On Tue, Dec 13, 2022 at 05:30:57PM -0700, Jim Fehlig wrote:
>> Introduce the libvirt-daemon-plugin-lockd subpackage to provide the
>> client-side lockd plugin for virtlockd.
>>
>> The sanlock plugin also needs the directory %{_libdir}/libvirt/lock-driver,
>> which it currently gets via the libvirt-daemon dependency. Duplicate the
>> directory in the %files section of the sanlock plugin, allowing the
>> libvirt-daemon dependency to be dropped.
> 
> I think it would be slightly neater if you introduced the new package
> with a dependency on libvirt-daemon and left the existing dependency
> in the sanlock package alone. Then, after introducing the
> libvirt-daemon-common package, you could replace those dependencies
> with the more lightweight ones at the same time as you're doing so
> for all other packages.

That patch starts with libvirt-daemon getting a dependency on 
libvirt-daemon-plugin-lockd :-). That dependency is needed to ensure we still 
get lockd.so when installing libvirt-daemon.

What if I leave the directory in libvirt-daemon in this patch, then duplicate it 
and drop the libvirt-daemon dependency when renaming the sanlock package?

Regards,
Jim



More information about the libvir-list mailing list