[PATCH V2 9/9] kbase: Update rpm-deployment.rst with new subpackages

[Jim Fehlig]

On 12/15/22 08:50, Andrea Bolognani wrote:
> On Wed, Dec 14, 2022 at 02:55:30PM -0700, Jim Fehlig wrote:
>> On 12/14/22 11:08, Andrea Bolognani wrote:
>>> On Tue, Dec 13, 2022 at 05:31:02PM -0700, Jim Fehlig wrote:
>>>> +* libvirt-daemon-plugin-lockd
>>>> +  This package provides the lockd.so module, a daemon plugin for communicating
>>>> +  with a virtlockd configured to use POSIX fcntl advisory locks.
>>>> +
>>>> +* libvirt-daemon-plugin-sanlock
>>>> +  This package provides the sanlock.so module, a daemon plugin for communicating
>>>> +  with a virtlockd configured to use sanlock.
>>>
>>> Based on Dan's explanation, these descriptions are not accurate: the
>>> lockd.so module is used by the hypervisor driver to manage locks via
>>> virtlockd, while the sanlock.so to do the same via sanlock.
>>
>> I think the first one is accurate. lockd.so is a plugin for daemons to
>> communicate with virtlockd. Daniel wrote
>>
>> "virtqemud locks(sic) the lockd.so plugin, as lockd.so
>> provides the client impl to talk to virtlockd. Think of lockd.so
>> as being equiv of libvirt.so".
>>
>> I assume sanlock.so is the same. It provides the client impl for daemons to
>> talk to virtlockd's sanlock backend. Regardless, suggestions on the actual
>> text to put here would be much appreciated.
> 
> My understanding is that configuring the hypervisor driver to use
> sanlock results in it loading the sanlock.so plugin and calling out
> to sanlock directly, without going through virtlockd. virlockd is
> used when lockd.so is loaded. Basically the plugins provide the
> implementation of the locking interface, with the backend being
> sanlock and virtlockd respectively.
> 
> But I'm not 100% positive so let's wait for Dan to either confirm or
> debunk this take O:-)

Confirmed :-).

> Assuming it's correct, the descriptions could be along the lines of
> 
>    * libvirt-daemon-plugin-lockd
>      This package provides the lockd.so module, a daemon plugin that
>      implements disk locking using POSIX fcntl advisory locks via
>      communication with the virtlockd daemon.

Sounds good.

>    * libvirt-daemon-plugin-sanlock
>      This package provides the sanlock.so module, a daemon plugin that
>      implements disk locking via communication with the sanlock
>      daemon.

I missed that a description for the libvirt-lock-sanlock package already exists 
in this file. I'll update it in 5/9 and only include the 
libvirt-daemon-plugin-lockd addition here.

Regards,
Jim