[PATCH 0/3] Introduce and use virDirOpenSorted()

Michal Privoznik mprivozn at redhat.com
Fri Dec 23 08:35:27 UTC 2022


Whiles working on Hyper-V patches I've posted yesterday I ran
domaincapstest occasionally and was puzzled for a moment that qemu-7.2.0
wasn't tested. Well it is, but it's harder to see immediately because
individual test cases are in 'random' order:

11) qemu_7.2.0.x86_64                                                 ... OK
....
46) qemu_5.1.0.sparc                                                  ... OK
47) qemu_6.1.0.x86_64                                                 ... OK
48) qemu_6.1.0-q35.x86_64                                             ... OK
49) qemu_6.1.0-tcg.x86_64                                             ... OK
50) qemu_7.0.0.ppc64                                                  ... OK
51) qemu_6.2.0.x86_64                                                 ... OK
52) qemu_6.2.0-q35.x86_64                                             ... OK
53) qemu_6.2.0-tcg.x86_64                                             ... OK

Huge thanks to Martin, who helped me realize (in 2/3) that 'struct
dirent' while declared as 'char d_name[256]' is rather peculiar and a
little dance is needed to copy it properly.

Michal Prívozník (3):
  util: Introduce a wrapper struct around DIR
  util: Introduce virDirOpenSorted()
  tests: Use virDirOpenSorted()

 build-aux/syntax-check.mk            |   2 +-
 src/bhyve/bhyve_capabilities.c       |   2 +-
 src/bhyve/bhyve_firmware.c           |   2 +-
 src/conf/capabilities.c              |   8 +-
 src/conf/virdomainobjlist.c          |   2 +-
 src/conf/virnetworkobj.c             |   8 +-
 src/conf/virnwfilterbindingobjlist.c |   2 +-
 src/conf/virnwfilterobj.c            |   2 +-
 src/conf/virsecretobj.c              |   2 +-
 src/conf/virstorageobj.c             |   4 +-
 src/libvirt_private.syms             |   1 +
 src/node_device/node_device_udev.c   |   2 +-
 src/openvz/openvz_conf.c             |   2 +-
 src/qemu/qemu_domain.c               |   2 +-
 src/qemu/qemu_driver.c               |   4 +-
 src/qemu/qemu_interop_config.c       |   2 +-
 src/security/security_selinux.c      |   4 +-
 src/storage/storage_backend_iscsi.c  |   2 +-
 src/storage/storage_util.c           |  10 +-
 src/util/vircgroup.c                 |   4 +-
 src/util/vircgroupv1.c               |   2 +-
 src/util/vircommand.c                |   2 +-
 src/util/virdevmapper.c              |   2 +-
 src/util/virfile.c                   | 146 ++++++++++++++++++++++-----
 src/util/virfile.h                   |  16 +--
 src/util/virhook.c                   |   4 +-
 src/util/virhostcpu.c                |   6 +-
 src/util/virmdev.c                   |   4 +-
 src/util/virnetdev.c                 |   2 +-
 src/util/virnuma.c                   |   2 +-
 src/util/virpci.c                    |   8 +-
 src/util/virprocess.c                |   2 +-
 src/util/virresctrl.c                |   8 +-
 src/util/virscsi.c                   |   4 +-
 src/util/virscsihost.c               |   2 +-
 src/util/virusb.c                    |   2 +-
 src/util/virutil.c                   |   4 +-
 src/util/virvhba.c                   |   6 +-
 tests/testutilsqemu.c                |   8 +-
 tests/virschematest.c                |   4 +-
 tools/virt-host-validate-common.c    |   2 +-
 41 files changed, 201 insertions(+), 102 deletions(-)

-- 
2.38.2



More information about the libvir-list mailing list