[PATCH V4 07/11] spec: Add module-init-tools dependency to nodedev and lxc drivers

[Andrea Bolognani]

On Thu, Dec 22, 2022 at 11:03:38AM -0700, Jim Fehlig wrote:
> @@ -571,6 +571,8 @@ Requires: libvirt-libs = %{version}-%{release}
>  Requires: systemd >= 185
>  # For managing persistent mediated devices
>  Requires: mdevctl
> +# for modprobe of pci devices
> +Requires: module-init-tools
>
>  %description daemon-driver-nodedev
>  The nodedev driver plugin for the libvirtd daemon, providing
> @@ -776,6 +778,8 @@ Requires: libvirt-libs = %{version}-%{release}
>  # There really is a hard cross-driver dependency here
>  Requires: libvirt-daemon-driver-network = %{version}-%{release}
>  Requires: systemd-container
> +# for modprobe of nbd driver
> +Requires: module-init-tools

Shouldn't you be able to drop the corresponding dependency from
libvirt-daemon at this point? I would assume that the driver itself,
not the common daemon code, calls modprobe, so a deployment where the
daemon is installed but neither of these drivers is doesn't need the
module-init-tools package to be present.

-- 
Andrea Bolognani / Red Hat / Virtualization