[libvirt PATCH v2 3/3] qemu: add tests for the ISA debug console command line

[Andrea Bolognani]

On Wed, Feb 02, 2022 at 12:44:45PM +0000, Daniel P. Berrangé wrote:
> +++ b/tests/qemuxml2argvdata/serial-debugcon.xml
> @@ -0,0 +1,29 @@
> +<domain type='qemu'>
> +  <name>QEMUGuest1</name>
> +  <uuid>c7a5fdbd-edaf-9455-926a-d65c16db1809</uuid>
> +  <memory unit='KiB'>219136</memory>
> +  <currentMemory unit='KiB'>219136</currentMemory>
> +  <vcpu placement='static'>1</vcpu>
> +  <os>
> +    <type arch='x86_64' machine='pc'>hvm</type>
> +    <boot dev='hd'/>
> +  </os>
> +  <clock offset='utc'/>
> +  <on_poweroff>destroy</on_poweroff>
> +  <on_reboot>restart</on_reboot>
> +  <on_crash>destroy</on_crash>
> +  <devices>
> +    <emulator>/usr/bin/qemu-system-x86_64</emulator>
> +    <disk type='block' device='disk'>
> +      <source dev='/dev/HostVG/QEMUGuest1'/>
> +      <target dev='hda' bus='ide'/>
> +      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
> +    </disk>

The <disk> part is irrelevant to the scenario we're testing here and
can be safely dropped.

> +    <serial type='pty'>
> +      <target type='isa-debug'>
> +        <model name='isa-debugcon'/>
> +      </target>

Turning this into

  <target type='isa-debug'/>

would ensure that <model> is filled in automatically with the correct
value.


Whether or not you decide do apply the changes suggested above

  Reviewed-by: Andrea Bolognani <abologna at redhat.com>


I think this new feature warrants an entry in the release notes. Feel
free to post that as a follow-up :)

-- 
Andrea Bolognani / Red Hat / Virtualization