[libvirt PATCH v8 0/3] Ignore EPERM on implicit clearing of VF VLAN ID

Dmitrii Shcherbakov dmitrii.shcherbakov at canonical.com
Thu Feb 3 16:41:53 UTC 2022


Thanks again for the feedback - much appreciated!

Best Regards,
Dmitrii Shcherbakov
LP/MM/oftc: dmitriis

On Thu, Feb 3, 2022 at 6:52 PM Michal Prívozník <mprivozn at redhat.com> wrote:
>
> On 2/3/22 15:45, Laine Stump wrote:
> > On 2/2/22 1:04 PM, Michal Prívozník wrote:
> >>
> >> Laine, any thoughts?
> >
> > I somehow thought this had already been pushed, so I was surprised when
> > it showed up again :-/
> >
> > I think the only issue I had before was that I thought the new unit
> > tests were more testing the test setup than the actual code, but Dan
> > convinced me otherwise.
> >
> > So I'm fine with this change.
> >
>
> Cool, pushed now.
>
> > A newly discovered (but pre-existing, so non-consequential to these
> > patches) problem associated with vlans is that we don't differentiate
> > between "set vlan 0" and "don't set any vlan", which I hadn't even
> > considered before, until this BZ came up:
> >
> >  https://bugzilla.redhat.com/2035726
> >
> > (The reporter is trying to use <tag id='-1'/> to "unset" the vlan tag
> > for an interface)
> >
>
> Ah, but the bug report is for openvswitch port profile, so that's doubly
> unrelated :-)
>
> Michal
>





More information about the libvir-list mailing list