[PATCH] qemu: fix formatting of pflash readonly attribute
Ján Tomko
jtomko at redhat.com
Mon Feb 7 17:04:37 UTC 2022
On a Monday in 2022, Daniel P. Berrangé wrote:
>When the <loader> had an explicit readonly='no' attribute we
>accidentally still marked the plfash as readonly due to the
>bad conversion from virTristateBool to bool.
>
>Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
>---
> src/qemu/qemu_domain.c | 3 +-
> .../bios-nvram-implicit-rw.x86_64-latest.args | 39 +++++++++++++++++++
> .../bios-nvram-implicit-rw.xml | 35 +++++++++++++++++
> .../bios-nvram-rw.x86_64-latest.args | 39 +++++++++++++++++++
> tests/qemuxml2argvdata/bios-nvram-rw.xml | 35 +++++++++++++++++
> tests/qemuxml2argvtest.c | 2 +
> 6 files changed, 152 insertions(+), 1 deletion(-)
> create mode 100644 tests/qemuxml2argvdata/bios-nvram-implicit-rw.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/bios-nvram-implicit-rw.xml
> create mode 100644 tests/qemuxml2argvdata/bios-nvram-rw.x86_64-latest.args
> create mode 100644 tests/qemuxml2argvdata/bios-nvram-rw.xml
>
Reviewed-by: Ján Tomko <jtomko at redhat.com>
Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220207/a8c0f27d/attachment-0001.sig>
More information about the libvir-list
mailing list