[PATCH 1/2] qemu_process.c: Fix VIR_QEMU_PROCESS_START_RESET_NVRAM value

[Daniel P. Berrangé]

On Wed, Feb 09, 2022 at 09:39:49AM +0100, Michal Privoznik wrote:
> In one of recent commits qemuProcessStartFlags enum gained new
> value: VIR_QEMU_PROCESS_START_RESET_NVRAM but due to a typo it
> has the same value as another member of the enum. Fix that.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_process.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/qemu/qemu_process.h b/src/qemu/qemu_process.h
> index f6c0d63d11..f6dd3f5104 100644
> --- a/src/qemu/qemu_process.h
> +++ b/src/qemu/qemu_process.h
> @@ -79,7 +79,7 @@ typedef enum {
>      VIR_QEMU_PROCESS_START_PRETEND      = 1 << 3,
>      VIR_QEMU_PROCESS_START_NEW          = 1 << 4, /* internal, new VM is starting */
>      VIR_QEMU_PROCESS_START_GEN_VMID     = 1 << 5, /* Generate a new VMID */
> -    VIR_QEMU_PROCESS_START_RESET_NVRAM  = 1 << 5, /* Re-initialize NVRAM from template */
> +    VIR_QEMU_PROCESS_START_RESET_NVRAM  = 1 << 6, /* Re-initialize NVRAM from template */
>  } qemuProcessStartFlags;

facepalm.  Shame there's no compiler warning for this scenario. Though
we do it intentionally in a handful of places, it would be better to
warn by default and selectively hide it with a pragma.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|