[PATCH 2/5] qemuFirmwareFillDomain: Use FW descriptors to lookup template when resetting NVRAM

Daniel P. Berrangé berrange at redhat.com
Thu Feb 10 16:05:46 UTC 2022


On Thu, Feb 10, 2022 at 12:13:23PM +0100, Michal Privoznik wrote:
> If VIR_QEMU_PROCESS_START_RESET_NVRAM flag is passed when
> starting a domain, then user requested to overwrite the domain
> specific NVRAM with the one from template. But it is very likely
> that the path to the template is not stored in the domain
> definition, which in turn makes the copy function
> (qemuPrepareNVRAM()) fail.
> 
> The solution is simple - when preparing domain, specifically when
> deciding whether the path to the template should be autofilled,
> ignore any existing NVRAM file.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/qemu/qemu_firmware.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list