[PATCH 15/27] qemuDomainRemoveChrDevice: Detach fdset after chardev hot-unplug

[Ján Tomko]

On a Wednesday in 2022, Peter Krempa wrote:
>Our code uses fdsets for the pipe passed from virtlogd to qemu, but the
>chardev hot-unplug code neglected to detach the fdset after the chardev
>was removed. This kept the FDs open by qemu even after they were not
>used any more.
>
>After the refactor to use qemuFDPass for chardevs we now configure the
>'opaque' field for fdsets used for chardevs so we can use
>qemuHotplugRemoveFDSet to remove the unused fdset.
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_hotplug.c | 1 +
> tests/qemuhotplugtest.c | 4 ++--
> 2 files changed, 3 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220210/4f52ea78/attachment-0001.sig>