[PATCH v2 0/3] src: use virDomainJobData

Kristina Hanicova khanicov at redhat.com
Fri Feb 11 13:49:04 UTC 2022


v1 is here:
https://listman.redhat.com/archives/libvir-list/2022-January/msg00958.html

diff to v1:
* rebase onto the current master

(bellow are the ones suggested by Jirka, thanks)
* removed check if callbacks exists when cb struct exists
* renamed functions from qemuDomainJobInfoX to qemuDomainJobDataX
* moved qemuDomainJobSetStatsType to qemu_domainjob.c, dropped "Private"
  from the name and changed the prototype to take virDomainJobData*

I did not move qemuDomainJobDataUpdateTime to domain_job.c as Jirka
suggested, because I plan to move more functions to domain_job.c in the
next series. Stay tuned.

Kristina Hanicova (3):
  qemu: use generalized virDomainJobData instead of qemuDomainJobInfo
  qemu: make separate function for setting statsType of privateData
  libxl: use virDomainJobData instead of virDomainJobInfo

 src/hypervisor/domain_job.c      |  78 ++++++++++
 src/hypervisor/domain_job.h      |  72 ++++++++++
 src/hypervisor/meson.build       |   1 +
 src/libvirt_private.syms         |   7 +
 src/libxl/libxl_domain.c         |  10 +-
 src/libxl/libxl_domain.h         |   3 +-
 src/libxl/libxl_driver.c         |  14 +-
 src/qemu/qemu_backup.c           |  42 +++---
 src/qemu/qemu_backup.h           |   4 +-
 src/qemu/qemu_domainjob.c        | 237 ++++++++++++++++---------------
 src/qemu/qemu_domainjob.h        |  57 ++------
 src/qemu/qemu_driver.c           | 111 ++++++++-------
 src/qemu/qemu_migration.c        | 189 ++++++++++++------------
 src/qemu/qemu_migration.h        |   4 +-
 src/qemu/qemu_migration_cookie.c |  60 ++++----
 src/qemu/qemu_migration_cookie.h |   2 +-
 src/qemu/qemu_process.c          |  23 +--
 src/qemu/qemu_snapshot.c         |   3 +-
 18 files changed, 544 insertions(+), 373 deletions(-)
 create mode 100644 src/hypervisor/domain_job.c
 create mode 100644 src/hypervisor/domain_job.h

-- 
2.34.1




More information about the libvir-list mailing list