[PATCH 5/8] virDriverFeatureIsGlobal: Handle VIR_DRV_FEATURE_TYPED_PARAM_STRING

Peter Krempa pkrempa at redhat.com
Wed Feb 16 15:41:09 UTC 2022


This was a lockout to make strings in typed parameters compatible with
versions which didn't have them. Now all drivers need to expose this
capability.

This namely enables it for 'esx' and 'vz' drivers, while they don't seem
to be implementing any parameters for now, they might later.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/driver.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/driver.c b/src/driver.c
index 9852a1cb17..d070861cfd 100644
--- a/src/driver.c
+++ b/src/driver.c
@@ -353,7 +353,13 @@ virDriverFeatureIsGlobal(virDrvFeature feat,
         *supported = 0;
         return true;

+    /* Limitation of string support in typed parameters was an RPC limitation.
+     * At this point everything supports them and thus also drivers need to
+     * always advertise this feature */
     case VIR_DRV_FEATURE_TYPED_PARAM_STRING:
+        *supported = 1;
+        return true;
+
     case VIR_DRV_FEATURE_NETWORK_UPDATE_HAS_CORRECT_ORDER:
     case VIR_DRV_FEATURE_FD_PASSING:
     case VIR_DRV_FEATURE_MIGRATION_V2:
-- 
2.35.1




More information about the libvir-list mailing list