[libvirt PATCH 3/4] ci: manifest: Publish RPMs as artifacts on CentOS Stream and Fedoras

[Andrea Bolognani]

On Mon, Jan 31, 2022 at 07:01:00PM +0100, Erik Skultety wrote:
> We're already building libvirt in the containers already,

You already used "already" in this sentence already ;)

> if we publish
> the build in form of, say, RPMs,

No need to be vague - we're publishing them *exactly* as RPMs.

> +++ b/.gitlab-ci.yml
> @@ -30,7 +30,8 @@ include: '/ci/gitlab.yml'
>      - meson dist -C build --no-tests
>      - if test -x /usr/bin/rpmbuild && test "$RPM" != "skip";
>        then
> -        rpmbuild --nodeps -ta build/meson-dist/libvirt-*.tar.xz;
> +        rpmbuild --clean --nodeps --define "_topdir $PWD/rpmbuild" -ta build/meson-dist/libvirt-*.tar.xz;
> +        mv rpmbuild/RPMS/x86_64 libvirt-rpms ;

No whitespace before ";" please. I'd also like to have "/" at the end
of each directory name to make it obvious that we're moving around
directories rather than files.

> +++ b/ci/gitlab.yml
> @@ -407,6 +407,11 @@ x86_64-centos-stream-8:
>    allow_failure: false
>    variables:
>      NAME: centos-stream-8
> +  artifacts:
> +    expire_in: 1 day
> +    paths:
> +      - libvirt-rpms
> +
>
>  x86_64-centos-stream-9:
>    extends: .native_build_job

This looks like it's adding additional empty lines, and if you
regenerate the file using 'lcitool manifest' you'll find that they
get removed. But they are actually supposed to be there, and the fact
that they aren't is a bug in lcitool.

https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/226

-- 
Andrea Bolognani / Red Hat / Virtualization