[libvirt PATCH v2] Make systemd unit ordering more robust

Michal Prívozník mprivozn at redhat.com
Tue Feb 22 09:22:31 UTC 2022


On 2/15/22 15:52, Martin Kletzander wrote:
> Since libvirt-guests script/service can operate on various URIs and we do
> support both socket activation and traditional services, the ordering should be
> specified for all the possible sockets and services.
> 
> Also remove the Wants= dependency since do not want to start any service.  We
> cannot know which one libvirt-guests is configured, so we'd have to start all
> the daemons which would break if unused colliding services are not
> masked (libvirtd.service in the modular case and all the modular daemon service
> units in the monolithic scenario).  Fortunately we can assume that the system is
> configured properly to start services/sockets that are of interest to the user.
> That also works with the setup described in https://libvirt.org/daemons.html .
> 
> To make it even more robust we add the daemon service into the machine units
> created for individual domains as it was missing there.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1868537
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  src/util/virsystemd.c           |  8 ++++++--
>  tools/libvirt-guests.service.in | 12 +++++++++++-
>  2 files changed, 17 insertions(+), 3 deletions(-)

Reviewed-by: Michal Privoznik <mprivozn at redhat.com>

Michal




More information about the libvir-list mailing list