[libvirt][PATCH RESEND v10 4/5] conf: Introduce SGX EPC element into device memory xml

[Yang, Lin A]

On 2/16/22, 2:25 AM, "Michal Prívozník" <mprivozn at redhat.com> wrote:

> > @@ -7920,7 +7925,9 @@ Example: usage of the memory devices
> >     1.2.14` Provide ``nvdimm`` model that adds a Non-Volatile DIMM module.
> >     :since:`Since 3.2.0` Provide ``virtio-pmem`` model to add a paravirtualized
> >     persistent memory device. :since:`Since 7.1.0` Provide ``virtio-mem`` model
> > -   to add paravirtualized memory device. :since:`Since 7.9.0`
> > +   to add paravirtualized memory device. :since:`Since 7.9.0` Provide
> > +   ``sgx-epc`` model to add a SGX enclave page cache (EPC) memory to the guest.
> > +   :since:`Since 8.0.0`
> >
>
> Since 8.1.0.

Sure, I will update this.

> > diff --git a/tests/qemuxml2xmloutdata/sgx-epc.x86_64-latest.xml b/tests/qemuxml2xmloutdata/sgx-epc.x86_64-latest.xml
> > new file mode 100644
> > index 0000000000..1f2a9c418f
> > --- /dev/null
> > +++ b/tests/qemuxml2xmloutdata/sgx-epc.x86_64-latest.xml
> > @@ -0,0 +1,52 @@
> > +<domain type='qemu'>
>
> Effectively, what we want to test here is that XML can be parsed and
> formatted back. In this case we don't really care whether devices are
> automatically inserted. Having said that, this output XML can be just a
> symlink to the original XML.

Sorry, I might not fully understand this parse and re-formant test case
details. The re-formatted XML contains some tags don’t exist in original
XML, for example, the virtio memballoon device,

    <memballoon model='virtio'>
      <address type='pci' domain='0x0000' bus='0x01' slot='0x00' function='0x0'/>
    </memballoon>

This test case will fail if symlink to the original XML. Could you share how
to resolve it? Really appreciated.

Thanks,
Lin.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220223/fea2d784/attachment-0001.htm>