[PATCH] qemu: block copy: Propagate 'detect_zeroes' properly into mirror definition

Ján Tomko jtomko at redhat.com
Wed Feb 23 14:12:58 UTC 2022


On a Wednesday in 2022, Peter Krempa wrote:
>'qemuDomainPrepareDiskSourceData' propagates 'detect_zeroes' only for
>the disk source image, but the mirror destination has the ambition to
>replace the disk source when the job is finished, so we need to
>propagate the 'detect_zeroes' setting also in that case.
>
>Unfortunately it would become very hairy to either set 'disk->mirror'
>sooner or propagate that we want this done into
>'qemuDomainPrepareDiskSourceData', so the most straightforward solution
>is to do the propagation inside 'qemuDomainBlockCopyCommon'.
>
>Closes: https://gitlab.com/libvirt/libvirt/-/issues/277
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220223/ba264c54/attachment-0001.sig>


More information about the libvir-list mailing list