[libvirt PATCH 1/5] nwfilter: stop using recursive mutex for IP learning
Daniel P. Berrangé
berrange at redhat.com
Mon Feb 28 16:15:15 UTC 2022
On Mon, Feb 28, 2022 at 11:05:09AM -0500, Laine Stump wrote:
> On 2/25/22 10:30 AM, Daniel P. Berrangé wrote:
> > The virNWFilterLockIface method is only called from one place,
> > the learnIPAddressThread method.
>
> nwfilter_gentech_driver.c:virNWFilterDoInstantiate() and
> _virNWFilterTeardownFilter() also call virNWFilterLockIface.
Sigh, yes.
I didn't properly consider that stuff outside of
learnip.c would be using its mutex. We should move
the iface locking into the gentech driver to make
it clear is is shared functionality.
Consider this patch dropped.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
More information about the libvir-list
mailing list