[libvirt PATCH v2 2/6] docs: Add <link> pointing to favicon.ico

[Daniel P. Berrangé]

On Tue, Dec 21, 2021 at 04:30:29PM +0100, Andrea Bolognani wrote:
> It's not strictly necessary when the icon lives in the top-level
> directory of the website, as browsers will fall back to that
> path when the <link> element is absent, but it's still considered
> good practice to spell out the path explicitly.

On the contrary, it is not good practice, as it breaks some
browsers. This was explicitly omitted:

  https://realfavicongenerator.net/faq#why_ico_not_declared

> Signed-off-by: Andrea Bolognani <abologna at redhat.com>
> ---
>  docs/page.xsl | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/docs/page.xsl b/docs/page.xsl
> index 580387ac59..52716ba4a5 100644
> --- a/docs/page.xsl
> +++ b/docs/page.xsl
> @@ -93,6 +93,7 @@
>          <meta name="viewport" content="width=device-width, initial-scale=1"/>
>          <link rel="stylesheet" type="text/css" href="{$href_base}main.css"/>
>          <link rel="apple-touch-icon" sizes="180x180" href="/apple-touch-icon.png"/>
> +        <link rel="shortcut icon" href="/favicon.ico"/>
>          <link rel="icon" type="image/png" sizes="32x32" href="/favicon-32x32.png"/>
>          <link rel="icon" type="image/png" sizes="16x16" href="/favicon-16x16.png"/>
>          <link rel="manifest" href="/manifest.json"/>
> -- 
> 2.31.1
> 

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|