[RFC v2 1/1] qemu: add index for isa-serial device using target.port

Ani Sinha ani at anisinha.ca
Tue Jan 4 12:26:23 UTC 2022



On Tue, 4 Jan 2022, Divya Garg wrote:

> On 04/01/22 5:47 pm, Ani Sinha wrote:
> >
> > On Mon, 3 Jan 2022, Divya Garg wrote:
> >
> > > Thankyou Ani for the review. I will be taking up the comments
> > > in next patchset along with other comments.
> > >
> > > On 03/01/22 1:44 pm, Ani Sinha wrote:
> > >
> > > > On Mon, 3 Jan 2022, Divya Garg wrote:
> > > >
> > > > > Hi all !
> > > > >
> > > > > Looking forward for the review comments on the patch.
> > > > >
> > > > For single patches, no need to use numbering.
> > > I have also added the cover letter with the patch. Hence added the
> > > numbering
> > > here.
> > btw, cover letters are not essential for single patches:
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__libvirt.org_submitting-2Dpatches.html&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=2QGHz-fTCVWImEBKe1ZcSe5t6UfasnhvdzD5DcixwOE&m=neaBi0ZuC9uGNNnNZGkXsPK_JEReYD2oA8csE4KE4LUYwtOWFxn6ipCd7_mPXNll&s=u-g3In7hJ90OdEzNmUj41bzzvmAIvOmLJSBpcAB2kQc&e=
>
> Thankyou so much Ani. I added the cover letter because i was not sure if the
> checks I am applying are needed or not. Hence wanted to explain all my cases
> that I am handling through the cover letter.

yes that's perfectly fine.




More information about the libvir-list mailing list