[PATCH 0/8] Fix an unfortunate deadlock

Martin Kletzander mkletzan at redhat.com
Tue Jan 4 13:47:04 UTC 2022


Before this series:

# LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd
<possible_deadlock>

After this series:

# LIBVIRT_LOG_OUTPUTS=1:asdf:fdsa:meh libvirtd
libvirt:  error : invalid argument: Invalid destination 'asdf' for output '1:asdf:fdsa:meh'


Martin Kletzander (8):
  util: Report error in virLogParseDefaultPriority
  util: Do not hide errors in virLogSetDefaultOutput
  util: Report error in virLogSetDefaultOutputToFile
  util: Initialize virLogMutex statically
  Exit on errors from virDaemonSetupLogging
  util: Check for errors in virLogSetFromEnv
  Dispatch error in virInitialize
  Do not print error in remote_daemon.c:main

 src/admin/libvirt-admin.c      |  3 ++-
 src/libvirt.c                  | 35 ++++++++++-----------------
 src/locking/lock_daemon.c      | 15 ++++++------
 src/logging/log_daemon.c       | 15 ++++++------
 src/lxc/lxc_controller.c       |  3 ++-
 src/remote/remote_daemon.c     | 19 +++++++--------
 src/remote/remote_ssh_helper.c |  3 ++-
 src/security/virt-aa-helper.c  |  3 ++-
 src/util/vircommand.c          |  3 ++-
 src/util/virdaemon.c           | 34 ++++++++++++++++----------
 src/util/virdaemon.h           | 14 +++++------
 src/util/virlog.c              | 44 ++++++++++++++++++++++------------
 src/util/virlog.h              |  4 ++--
 tests/testutils.c              |  4 +++-
 14 files changed, 111 insertions(+), 88 deletions(-)

-- 
2.34.1




More information about the libvir-list mailing list