[RFC v2 1/1] qemu: add index for isa-serial device using target.port

[Daniel P. Berrangé]

On Tue, Jan 04, 2022 at 11:47:39AM +0000, John Levon wrote:
> On Sat, Dec 11, 2021 at 07:57:47PM -0800, “Divya wrote:
> 
> > From: Divya Garg <divya.garg at nutanix.com>
> > 
> > VM XML accepts target.port but this does not get passed while building the qemu
> > command line for this VM.
> 
> Apologies, I failed to notice this had been sent out to the list; Re-posting
> my comments from an internal thread, so all can see:
> 
> I don't think serial ports that are not isa-serial should clash with serial
> ports like this.
> 
> In fact, from what I can see, as "port" is not used for any other type, we
> should just completely ignore non-isa-serial ports here.

Agreed, conceptually the 'port' is only required to be unique within
the scope of the 'type' setting.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|