[libvirt PATCH 07/17] qemu: Introduce virQEMUCapsAccelStr

Daniel P. Berrangé berrange at redhat.com
Wed Jan 5 10:12:24 UTC 2022


On Wed, Jan 05, 2022 at 01:36:23AM -0800, Andrea Bolognani wrote:
> On Wed, Jan 05, 2022 at 09:23:09AM +0000, Daniel P. Berrangé wrote:
> > On Tue, Jan 04, 2022 at 07:52:46PM +0100, Andrea Bolognani wrote:
> > > +static const char *
> > > +virQEMUCapsAccelStr(virDomainVirtType type)
> > > +{
> > > +    if (type == VIR_DOMAIN_VIRT_KVM) {
> > > +        return "kvm";
> > > +    } else {
> > > +        return "tcg";
> > > +    }
> > > +}
> >
> > ..... VIR_ENUM_IMPL/DECL is a better long term plan. For enum
> > values that don't make sense for QEMU just return a placeholder
> > or something.
> 
> Agreed. Would you accept that as a separate patch that's still part
> of this series but applies after all the existing code changes? As I
> mention in the cover letter, I tried to keep Roman's original code
> intact as much as possible, and I would prefer to avoid making any
> non-trivial changes to it to keep the authorship story relatively
> straight.

Would still be bisectable, so that's ok.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




More information about the libvir-list mailing list