[libvirt PATCH 11/17] tests: Add HVF support to testutilsqemu

[Andrea Bolognani]

On Wed, Jan 05, 2022 at 11:14:20AM +0000, Daniel P. Berrangé wrote:
> On Wed, Jan 05, 2022 at 03:02:07AM -0800, Andrea Bolognani wrote:
> > What if I changed things so that both the HVF test cases and the
> > testutilsqemu bit above are only built on macOS? We'd still have the
> > weird mix of capabilities on that platform, but at least Linux would
> > be unaffected. We run the test suite on macOS as part of our CI
> > pipeline, so coverage wouldn't be any worse.
>
> I was thinking more like
>
>  - testQemuCapsInit  only adds TCG+KVM emulators
>  - testQemuCapsInitMacOS only adds TCG+HVF emulators
>
> In  qemuxml2argvtest.c do
>
>     virCapsPtr linuxCaps = driver->caps
>     driver->caps = testQemuCapsInitMacOS();
>     DO_TEST("hvf-blah",
>             QEMU_CAPS_HVF,
>             QEMU_CAPS_PIIX3_USB_UHCI,
> 	    ....
>             QEMU_CAPS_USB_HUB);
>
>     virObjectUnref(driver->caps);
>     driver->caps = linuxCaps;
>
> feels like it ought to be reasonably simple to get working

Okay, I'll give it a try.

-- 
Andrea Bolognani / Red Hat / Virtualization