[PATCH v1] virdnsmasq: fix runtime search for executable

[Olaf Hering]

Tue, 17 Aug 2021 15:13:05 +0200 Pavel Hrdina <phrdina at redhat.com>:

> On Wed, Aug 11, 2021 at 11:47:13AM +0200, Olaf Hering wrote:
> > dnsmasq is an optional binary which does not neccessary exist during build.
> >
> > Signed-off-by: Olaf Hering <olaf at aepfle.de>
> > ---
> >  src/util/virdnsmasq.c | 28 +++++++++++++++++++++++-----
> >  1 file changed, 23 insertions(+), 5 deletions(-)  
> 
> Is there any error or incorrect behavior that you are trying to fix?
> I did audit the code and within the virdnsmasq.c file we use the
> binaryPath with virCommandRun() which will do this same check before
> acutally execing, see virExec().

The error was, and still is today, like this:

Jan 10 12:53:36 rdma03 libvirtd[1725]: Cannot check dnsmasq binary dnsmasq: No such file or directory

How do you intent to fix this?

Olaf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220110/364b8ebc/attachment-0001.sig>