[PATCH v3 0/7] virdnsmasq: Lookup DNSMASQ in PATH

Michal Privoznik mprivozn at redhat.com
Wed Jan 12 08:47:51 UTC 2022

v3 of:


diff to v2:
- Make dnsmasqCapsGetBinaryPath() fail if dnsmasq is not found
- Change the way caps are constructed in networkxml2conftest
- More code cleanup

However, as I was going through the code I realized that what we really
do is check dnsmasq's version against the minimal required one (2.67).
No actual capabilities are parsed. This is due to cleanup merged earlier
this release (v8.0.0-rc1~138 and commits around). While we could drop
more code I figured it may be worth keeping it for future use. I mean,
one day we might want to have an capability for give feature.

Michal Prívozník (7):
  virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
  lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
  virdnsmasq: Lookup DNSMASQ in PATH
  virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
  networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
  virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
  virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()

 src/libvirt_private.syms    |  1 -
 src/util/virdnsmasq.c       | 50 ++++++++-----------------------------
 src/util/virdnsmasq.h       |  1 -
 tests/meson.build           |  1 +
 tests/networkmock.c         | 46 ++++++++++++++++++++++++++++++++++
 tests/networkxml2conftest.c | 46 ++++++++++++++++++++++++++++++----
 6 files changed, 98 insertions(+), 47 deletions(-)
 create mode 100644 tests/networkmock.c


More information about the libvir-list mailing list