[libvirt PATCH 03/14] virInterfaceDefDevFormat: Add missing error handling

Tim Wiederhake twiederh at redhat.com
Wed Jan 12 13:10:04 UTC 2022


Signed-off-by: Tim Wiederhake <twiederh at redhat.com>
---
 src/conf/interface_conf.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/conf/interface_conf.c b/src/conf/interface_conf.c
index f2b3804bec..150616bda9 100644
--- a/src/conf/interface_conf.c
+++ b/src/conf/interface_conf.c
@@ -1089,13 +1089,16 @@ virInterfaceDefDevFormat(virBuffer *buf,
                 virBufferAsprintf(buf, "<mac address='%s'/>\n", def->mac);
             break;
         case VIR_INTERFACE_TYPE_BRIDGE:
-            virInterfaceBridgeDefFormat(buf, def);
+            if (virInterfaceBridgeDefFormat(buf, def) < 0)
+                return -1;
             break;
         case VIR_INTERFACE_TYPE_BOND:
-            virInterfaceBondDefFormat(buf, def);
+            if (virInterfaceBondDefFormat(buf, def) < 0)
+                return -1;
             break;
         case VIR_INTERFACE_TYPE_VLAN:
-            virInterfaceVlanDefFormat(buf, def);
+            if (virInterfaceVlanDefFormat(buf, def) < 0)
+                return -1;
             break;
     }
 
-- 
2.31.1




More information about the libvir-list mailing list