[PATCH 3/3] qemuSnapshotCreate: Don't insert snapshot into list with VIR_DOMAIN_SNAPSHOT_CREATE_NO_METADATA

[Peter Krempa]

On Tue, Jan 11, 2022 at 15:53:22 +0100, Michal Prívozník wrote:
> On 1/11/22 10:53, Peter Krempa wrote:

[...]

> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2039131
> > Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> > ---
> >  src/qemu/qemu_snapshot.c | 25 +++++++++++++++----------
> >  1 file changed, 15 insertions(+), 10 deletions(-)
> > 
> > diff --git a/src/qemu/qemu_snapshot.c b/src/qemu/qemu_snapshot.c
> > index 9a5d3e60aa..e9fc9051c1 100644
> > --- a/src/qemu/qemu_snapshot.c
> > +++ b/src/qemu/qemu_snapshot.c
> > @@ -1756,7 +1756,7 @@ qemuSnapshotCreate(virDomainObj *vm,
> >                     virQEMUDriverConfig *cfg,
> >                     unsigned int flags)
> >  {
> > -
> > +    g_autoptr(virDomainMomentObj) noMetadataSnap = NULL;
> 
> Nitpick, this variable is used as a bool later, which creates double
> negative conditions like !noMetadataSnap. But I'm failing to suggest
> anything better.

I went with 'tmpsnap'. It is indeed temporary ;)