[PATCH 2/2 for 8.0] qemu: add index for isa-serial device using target.port

John Levon levon at movementarian.org
Thu Jan 13 13:45:20 UTC 2022

On Thu, Jan 13, 2022 at 06:47:26PM +0530, Ani Sinha wrote:

> > > I preferred your previous style to this one.
> >
> > Below is cleaner IMO: we don't repeat code, and the flow is much clearer.
> If you look at other functions for example qemuBuildVirtioDevProps() etc they
> follow the previous style. I think it's fine to return NULL from multiple
> points.
> In any case if the maintainers are fine with it , I'm ok. Style is trivial.

Sure, either is fine with me too, if needed.


More information about the libvir-list mailing list