[PATCH 00/11] Misc cleanups

Ján Tomko jtomko at redhat.com
Fri Jan 14 16:25:31 UTC 2022


On a Friday in 2022, Michal Privoznik wrote:
>Couple of cleanups I've done whilst looking around our code base.
>
>Michal Prívozník (11):
>  storage_file: Declare virStorageSourceParseRBDColonString only in one
>    header
>  virconf: Report an error in when virConfSetValue() fails
>  xen_xl: Check for virConfSetValue() retval
>  src: Declare and use g_autoptr(virConfValue)
>  virconf: Make virConfSetValue() clear consumed pointer
>  libxl: Don't use a static buffer in xenParseXLVnuma()
>  libxl: Allocate @libxldisk in xenParseXLDisk() on stack
>  xen_xl.c: Use g_autofree more
>  xen_xl.c: Use g_autoptr() for virCPUDef
>  libxl: Remove needless labels
>  virsh: Remove needless labels
>
> src/libxl/xen_common.c                        |  62 ++---
> src/libxl/xen_xl.c                            | 259 ++++++------------
> src/libxl/xen_xm.c                            |  18 +-
> src/storage_file/storage_source.h             |   5 -
> .../storage_source_backingstore.h             |   3 +-
> src/util/virconf.c                            |  19 +-
> src/util/virconf.h                            |   3 +-
> tools/virsh-host.c                            |  20 +-
> tools/vsh.c                                   |  11 +-
> 9 files changed, 135 insertions(+), 265 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220114/229b7abd/attachment-0001.sig>


More information about the libvir-list mailing list