[PATCH v4 00/13] virdnsmasq: Lookup DNSMASQ in PATH

[Andrea Bolognani]

On Mon, Jan 17, 2022 at 08:24:36AM -0800, Andrea Bolognani wrote:
> On Mon, Jan 17, 2022 at 04:19:14PM +0100, Michal Privoznik wrote:
> > Michal Prívozník (13):
> >   virdnsmasq: Drop @binaryPath argument from dnsmasqCapsNewEmpty()
> >   lib: Prefer g_autoptr(dnsmasqCaps) instead of explicit unref
> >   virdnsmasq: Drop @force argument of dnsmasqCapsRefreshInternal()
> >   virdnsmasq: Drop mtime member from struct _dnsmasqCaps
> >   virdnsmasq: Drop noRefresh member from from struct _dnsmasqCaps
> >   virdnsmasq: Drop !caps check from dnsmasqCapsRefreshInternal()
> >   virdnsmasq: Don't run 'dnsmasq --help'
> >   virdnsmasq: Lookup DNSMASQ in PATH
> >   virdnsmasq: Require non NULL @caps in dnsmasqCapsGetBinaryPath()
> >   networkxml2conftest: Use dnsmasqCapsNewFromBinary() to construct caps
> >   networkxml2conftest: Check if capabilities were created successfully
> >   virdnsmasq: Drop dnsmasqCapsNewFromBuffer()
> >   virdnsmasq: Join dnsmasqCapsNewEmpty() and dnsmasqCapsNewFromBinary()
>
> Reviewed-by: Andrea Bolognani <abologna at redhat.com>

These changes seem to have made ASAN very unhappy, see

  https://gitlab.com/MichalPrivoznik/libvirt/-/jobs/1985244739
  https://gitlab.com/MichalPrivoznik/libvirt/-/jobs/1985244740

Tim, do you have any idea why that would be the case? My uneducated
guess is that the environment needed by ASAN is somehow lost when the
dnsmasqmock.py script is called, but I'm unfamiliar with how these
tools actually work.

-- 
Andrea Bolognani / Red Hat / Virtualization